Comment 3 for bug 429353

Revision history for this message
Michael Nelson (michael.nelson) wrote : Re: [Bug 429353] Re: Move edge message to the footer, allow people to stop redirection

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Albisetti wrote:
> On Tue, Sep 15, 2009 at 11:18 AM, Michael Nelson
>> Third, I'm not sure why we'd want "Enable edge redirect" in the
>> site_message for edge, as it will only ever be seen when on edge (note:
>> on the homepage at launchpad.dev there is an option to re-enable the
>> redirection).
>
> The enable will only be for when it is disabled, which is basically
> what you toggle from the home page AFAIK. Bonus points if the redirect

Yes, there is already an enable button on the home page of lp.net and
this works fine. All I meant was that it doesn't make sense to put it in
the site_message - which only appears on edge (production doesn't use a
site_message at all). The site_message is just a config option - it does
not know of its environement - if one is defined it will be displayed in
the designated spot on the template.

So, I'm assuming that for this trivial fix I'll move the site_message to
the bottom and test and suggest the new configuration site_message that
should be used for edge (for the disable-redirect js-link). The current
re-enabling of redirects (from lp.net) will continue to work as is.

If you're actually wanting to have separate site_messages in different
locations for different envs, then we'd need a bit more
infrastructure/config changes.

- --
Michael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkqvY8kACgkQGSan/irvan0fcACfSu60RiIJLZZGuLsQ8cTMb23J
oHEAn36Wq7YSw+4cv/uAhSq9iW0fWRC3
=A7dg
-----END PGP SIGNATURE-----