Allow pending reviews to be deleted
Bug #323051 reported by
Tim Penhey
This bug affects 4 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Triaged
|
Low
|
Unassigned | ||
Bug Description
Pending reviews should be able to be deleted by anyone with edit permissions on the proposal.
Related branches
lp://staging/~thumper/launchpad/delete-pending-reviews
- Paul Hummer (community): Approve
-
Diff: 223 lines (+108/-9)7 files modifiedlib/canonical/launchpad/security.py (+8/-2)
lib/lp/code/browser/codereviewvote.py (+5/-1)
lib/lp/code/configure.zcml (+1/-2)
lib/lp/code/errors.py (+5/-0)
lib/lp/code/interfaces/codereviewvote.py (+9/-2)
lib/lp/code/model/codereviewvote.py (+7/-1)
lib/lp/code/model/tests/test_codereviewvote.py (+73/-1)
| Changed in launchpad-bazaar: | |
| importance: | Undecided → Medium |
| milestone: | none → 2.2.2 |
| status: | New → Triaged |
Revision history for this message
| Jonathan Lange (jml) wrote | #1 |
Revision history for this message
| Tim Penhey (thumper) wrote Re: [Bug 323051] Re: Allow pending reviews to be deleted | #2 |
| Changed in launchpad-bazaar: | |
| assignee: | nobody → thumper |
Revision history for this message
| Tim Penhey (thumper) wrote | #3 |
| Changed in launchpad-bazaar: | |
| milestone: | 2.2.2 → 2.2.3 |
| Changed in launchpad-bazaar: | |
| milestone: | 2.2.3 → 2.2.4 |
Revision history for this message
| Tim Penhey (thumper) wrote | #4 |
| Changed in launchpad-bazaar: | |
| assignee: | Tim Penhey (thumper) → nobody |
| milestone: | 2.2.4 → none |
Revision history for this message
| Tim Penhey (thumper) wrote | #5 |
| Changed in launchpad: | |
| status: | Triaged → Fix Released |
| status: | Fix Released → Triaged |
| importance: | Medium → Low |
| tags: | added: easy ui |
To post a comment you must log in.
This bug confuses me a little. Why should pending reviews be deletable over and above any other kind of review?