Comment 2 for bug 315123

On 09/01/09 11:47 AM, Diogo Matsubara wrote:
> Are reviews on behalf of a team really needed? If yes, can you elaborate
> further on the use case?
>
>
> ** Changed in: launchpad-bazaar
> Product: Launchpad itself => Launchpad Bazaar Integration
>
> ** Changed in: launchpad-bazaar
> Status: New => Incomplete
>
> ** Tags added: code-review confusing-ui
>

I'm not sure what the use case is for reviews on behalf of teams, but my guess
is that they indicate that you asked a specific group of people for a review,
and that a member of the group looked at your code. If this is the case, then I
don't feel that the UI clearly shows this intent.

Lets assume that a person has requested a review from "Canonical Launchpad
Developers", the ~launchpad team. The "Launchpad Developers" review request
line will have a status of "Pending".

In the current UI, if I click the [Review] link beside *my* name, then my review
will end up with a status like "Approved", but the "Launchpad Developers" review
status will still be "Pending", even though I'm a member of the ~launchpad team.
  It looks really weird.

Worse still, I can't go back and edit the ~launchpad team's review request
status - it's stuck as "Pending".