On Thu, Jun 18, 2009 at 11:29:58PM -0000, Martin Pool wrote:
> I don't see how indirecting through the database to get the old values
> helps because the amount of data is pretty small.
I was thinking that it would help for scenarios where people change
things via the API, which wouldn't have the second copy of the fields to
compare the changes against.
However, I've come to the conclusion that neither approach deals
perfectly with changes made via the API (or via AJAX elements, since
they use the API too), which is something of a problem. Whilst we could
mitigate that to some extent by making AJAX elements check for
collisions we can't really force other API users to do so.
Perhaps it would be sufficient to apply this for the whole bugtask / bug
edit forms, but as we move to an all-AJAX bug page that's going to
become less and less relevant for the majority of users.
On Thu, Jun 18, 2009 at 11:29:58PM -0000, Martin Pool wrote:
> I don't see how indirecting through the database to get the old values
> helps because the amount of data is pretty small.
I was thinking that it would help for scenarios where people change
things via the API, which wouldn't have the second copy of the fields to
compare the changes against.
However, I've come to the conclusion that neither approach deals
perfectly with changes made via the API (or via AJAX elements, since
they use the API too), which is something of a problem. Whilst we could
mitigate that to some extent by making AJAX elements check for
collisions we can't really force other API users to do so.
Perhaps it would be sufficient to apply this for the whole bugtask / bug
edit forms, but as we move to an all-AJAX bug page that's going to
become less and less relevant for the majority of users.