Launchpad itself

Translate paths back to virtual paths when handling errors in vfs transports

Bug #270076 reported by Jonathan Lange
2
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Wishlist
Unassigned
Launchpad itself
Triaged
Low
Unassigned

Bug Description

At the moment, people get errors like this from bzr:

 Format <RepositoryFormatKnit1> for bzr+ssh://<email address hidden>/%7Eubuntu-it-magazine/fcm-it/edizione-fcm-it/.bzr/ is deprecated - please use 'bzr upgrade' to get better performance
 starting upgrade of bzr+ssh://<email address hidden>/%7Eubuntu-it-magazine/fcm-it/edizione-fcm-it/
 making backup of tree history
 bzr: ERROR: File exists: '/srv/bazaar.launchpad.net/push-branches/00/00/23/89/backup.bzr'

We shouldn't show them the internal address — it's confusing and they don't need to know it. We should translate the paths in all errors raised from the virtual transport.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

This doesn't look too hard in fact, we can intercept PathError and translate that. We're not totally consistent about the way we invoke the methods on the underlying transport and I guess we'll be wanting to clean that up at the same time.

I'm not sure how to actual do the untranslation, how general to try to make it. Just hacking it wouldn't be hard, I think.

Changed in launchpad-bazaar:
status: New → Triaged
Revision history for this message
Jonathan Lange (jml) wrote :

At worst, we could add a new remote method that maps id -> unique name.

Changed in launchpad-bazaar:
importance: Undecided → Medium
Revision history for this message
Robert Collins (lifeless) wrote :

@mwhudson @jml is this done? I think it might be...

Changed in launchpad:
importance: Medium → High
Revision history for this message
Jonathan Lange (jml) wrote :

No, not yet:

(As someone who is not ~lifeless)
$ bzr push lp:~lifeless/+junk/gpgverify
bzr: ERROR: Cannot lock LockDir(lp-75755024:///~lifeless/%2Bjunk/gpgverify/.bzr/branchlock): Transport operation not possible: readonly transport

Should instead refer to "lp:~lifeless/+junk/gpgverify" – no escaping, no integer in URL scheme.

Revision history for this message
Robert Collins (lifeless) wrote :

This would be lovely to do. Probably needs some coordination in bzr itself. Not currently on our roadmaps, but patches gratefully accepted.

Changed in launchpad:
importance: High → Low
Changed in bzr:
status: New → Confirmed
importance: Undecided → Wishlist
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.