In summary, "no, this bug is not fixed". Martin believes that there is a deeper, underlying problem here, which is that there's no visual language for representing whole object actions. In particular, both he and Tim think that there should be a conceptually big button that says "Delete this branch" in text and also includes the trash icon.
Martin Pool believes that there should a general pattern that POST actions that return to the same page should always be done with buttons, or at least always grouped as the same.
As a concrete fix to this bug that *doesn't* involve major global UI design, we could move the trash (and pencil) icons down from after the branch title to the same area where "Propose for merging into another branch" is. We'd then have:
(+) Propose for merging into another branch
(/) Edit this branch
(T) Delete this branch
I'm talking to Martin Pool now.
In summary, "no, this bug is not fixed". Martin believes that there is a deeper, underlying problem here, which is that there's no visual language for representing whole object actions. In particular, both he and Tim think that there should be a conceptually big button that says "Delete this branch" in text and also includes the trash icon.
Martin Pool believes that there should a general pattern that POST actions that return to the same page should always be done with buttons, or at least always grouped as the same.
As a concrete fix to this bug that *doesn't* involve major global UI design, we could move the trash (and pencil) icons down from after the branch title to the same area where "Propose for merging into another branch" is. We'd then have:
(+) Propose for merging into another branch
(/) Edit this branch
(T) Delete this branch