Comment 9 for bug 250451

Revision history for this message
Wouter van Heyst (larstiq) wrote : Re: [Bug 250451] Re: bzr suggests wrong URL for break-lock with a LP hosted branch

On Sun, May 03, 2009 at 02:16:26AM -0000, Andrew Bennetts wrote:
> > Somewhere deep down some file-like object gets written to with the following bytes:
> > "d16:Software version7:1.15deves6l17:Branch.lock_write25:~larstiq/+junk/bug250451/0:0:ee"
>
> Ignoring headers and whatnot, this is just a simple HPSS call to
> Branch.lock_write:
>
> >>> bdecode("l17:Branch.lock_write25:~larstiq/+junk/bug250451/0:0:e")
> ['Branch.lock_write', '~larstiq/+junk/bug250451/', '', '']

Right.

> The -Dhpss logging would be an easier way to observe the HPSS traffic.
> As you notice, the useless URL is not coming from the client. The two
> most likely fixes are:
>
> a) make the client ignore whatever URL the server returns when generating the break-lock message, or
> b) make the server send usable URL (or maybe relpath) in its LockContention errors (and/or other lock-related errors).

I tried to do a), but I fail to see how to do that. At the point where
the message gets dumped to screen, it happens magically to me, without a
point where I can intervene.

I can not find the point in the code to apply a)

Wouter van Heyst