Comment 2 for bug 1678036

Revision history for this message
Robie Basak (racb) wrote :

> I would note that this would have been much easier for you if the commit message had simply quoted the bug numbers in the proper style...

That's an interesting point, thanks. Currently since our goal is a correct upload, we're not necessarily always doing this and don't have it documented in our process that we should.

However, I'd note that to review an SRU it's important that I review the set of bug links specifically from debian/changelog, rather than the set of bug links in commit messages. As part of the review, it matters if there are typos, missing or extraneous bug links in debian/changelog itself (and I've seen this happen). This could be mitigated by adding a cross-checking of this to my upcoming linting tool.