Comment 3 for bug 373259

Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

Nice and clean, +1!

[1]

+ """Alert activates when computers need to be rebooted."""

Maybe s/activates/activated/ ?

[2]

+ rule = self.account.create_rule(ComputerRebootAlert)

It looks like all tests eventually need this, what about moving it to self.setUp ? Or did you prefer not do it on purpose for better readability?

[3]

+ """
+ ComputerRebootAlert has a special email template displaying the list
+ of computers that require a reboot.
+ """

This test docstring is duplicated between test_email_notification and test_email_notification_with_many_computers.