commit c5320eb22386c34d83435fa0b9aa03b178996b52
Author: Mark Goddard <email address hidden>
Date: Thu Aug 6 10:50:25 2020 +0100
Fix kolla_set_configs --check with a directory
There are several issues with kolla_set_configs --check:
1. We calculate the destination path incorrectly when comparing a file
in a directory, due to passing arguments to os.path.relpath in the
wrong order
2. For directories that have not changed, we also attempt to compare
them as files, which fails when they are open()ed.
3. If the config JSON does not have a config_files key, it fails with a
KeyError.
The first two issues affect the fluentd container, which specifies
directories as the source, without using a glob. The third affects OVN
containers.
Reviewed: https:/ /review. opendev. org/745105 /git.openstack. org/cgit/ openstack/ kolla/commit/ ?id=c5320eb2238 6c34d83435fa0b9 aa03b178996b52
Committed: https:/
Submitter: Zuul
Branch: master
commit c5320eb22386c34 d83435fa0b9aa03 b178996b52
Author: Mark Goddard <email address hidden>
Date: Thu Aug 6 10:50:25 2020 +0100
Fix kolla_set_configs --check with a directory
There are several issues with kolla_set_configs --check:
1. We calculate the destination path incorrectly when comparing a file
in a directory, due to passing arguments to os.path.relpath in the
wrong order
2. For directories that have not changed, we also attempt to compare
them as files, which fails when they are open()ed.
3. If the config JSON does not have a config_files key, it fails with a
KeyError.
The first two issues affect the fluentd container, which specifies
directories as the source, without using a glob. The third affects OVN
containers.
This patch fixes these issues.
Closes-Bug: #1890567
Change-Id: I8921befe51da42 82121443849177a 7ca5ebe8822