Comment 8 for bug 1828826

Revision history for this message
Dino Ghilardi (dino-ghilardi) wrote : Re: [Bug 1828826] Re: symbol editor: Assert on "enter" key

On 14/05/19 09:56, Dino Ghilardi wrote:
> On 13/05/19 23:25, KiCad Janitor wrote:
>> Fixed in revision ef5c69167a493683c81d44cf752fc141dcf174de
>> https://git.launchpad.net/kicad/patch/?id=ef5c69167a493683c81d44cf752fc141dcf174de
>>
>>
>> ** Changed in: kicad
>>         Status: In Progress => Fix Committed
>>
>
> Testing commit ef5c69167a493683c81d44cf752fc141dcf174de: works for me too.
>
> Also the segfault on pcbnew when ending drawing operations with enter is
> working for me now.
>
> Now I have a new assert launching pcbnew "Assert failure" failed in
> UpdateHotKeys(): Duplicate hotkey definitions for <unknown>:
> pcbnew.Control.switchUnits and common.Control.toggleUnits", but I think
> this is a new bug, not related to the "enter" assert.
>
> Cheers,
> Dino.

Also the key is used in pcbnew/tools/pcbnew_control.cpp

TOOL_ACTION PCB_ACTIONS::switchUnits( "pcbnew.Control.switchUnits",
         AS_GLOBAL, TOOL_ACTION::LegacyHotKey( HK_SWITCH_UNITS ),
         "", "" );

and common/tool/actions.cpp
TOOL_ACTION ACTIONS::toggleUnits( "common.Control.toggleUnits",
+ AS_GLOBAL, TOOL_ACTION::LegacyHotKey( HK_SWITCH_UNITS ),
+ _( "Switch units" ), _( "Switch between inches and millimeters"
...

so it is not possible to work it around changing the hotkey assignment.

Cheers,
Dino.