Comment 3 for bug 1289115

Revision history for this message
Dave Chen (wei-d-chen) wrote :

The proposal for fixing this bug is submitted here: https://review.openstack.org/#/c/143772/

The previous check logic has a lot of issue with it, here are some explanation for the patch.

https://github.com/openstack/keystone/blob/master/keystone/contrib/ec2/controllers.py#L63 is not make sense, I think the intention of author would want to check whether the colon and port is existed in credentials['host'], the colon existed in credentials['signature'] and check against this sound absurd.

It's common to see the colon and port are ommited in the request header, but when they are presented there and the signature method is sanity a little bit, there is no case and no reason at all why they are split from the sign request. so the needless check against this will be never get effective.