kayobe

[RFE] Kayobe can't set STP flag on bridges

  1. Series yoga
  2. Bug #2028775
Bug #2028775 reported by Bartosz Bezak
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kayobe
Fix Released
Medium
Bartosz Bezak
Antelope
Fix Released
Medium
Bartosz Bezak
Yoga
Fix Committed
Medium
Bartosz Bezak
Zed
Fix Committed
Medium
Bartosz Bezak

Bug Description

Rocky Linux 9 by defaults sets STP flag on bridges to true, which in some cases is not advisable (BPDU Guard on switch ports). ansible-role-interfaces supports already stp flags. Let's add it to kayobe

Michal Nasiadka (mnasiadka)
summary: - Kayobe can't set STP flag on bridges
+ [RFE] Kayobe can't set STP flag on bridges
Changed in kayobe:
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Bartosz Bezak (bbezak)
Revision history for this message
Bartosz Bezak (bbezak) wrote :

https://review.opendev.org/c/openstack/kayobe/+/889859

Changed in kayobe:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (master)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/889859
Committed: https://opendev.org/openstack/kayobe/commit/f1fd127c34f07624b472e07c3e589080499b29dd
Submitter: "Zuul (22348)"
Branch: master

commit f1fd127c34f07624b472e07c3e589080499b29dd
Author: Bartosz Bezak <email address hidden>
Date: Thu Jul 27 13:11:12 2023 +0000

    Add STP option for bridge interfaces

    For Rocky Linux 9, Kayobe will now disable STP on a bridge by default,
    to preserve compatibility with network scripts, as Network Manager
    enables STP on all bridges by default.
    Enabling STP can lead to port down event if BPDU guard is enabled
    on the switch.

    Closes-Bug: #2028775

    Change-Id: I35eaa92f4243af00697306aa801e5a733885ce4f

Changed in kayobe:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/kayobe/+/891753

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/kayobe/+/891754

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/kayobe/+/891755

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/891753
Committed: https://opendev.org/openstack/kayobe/commit/d2b1fcafc4386e471aa81eda6af1affbba52ae75
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit d2b1fcafc4386e471aa81eda6af1affbba52ae75
Author: Bartosz Bezak <email address hidden>
Date: Thu Jul 27 13:11:12 2023 +0000

    Add STP option for bridge interfaces

    For Rocky Linux 9, Kayobe will now disable STP on a bridge by default,
    to preserve compatibility with network scripts, as Network Manager
    enables STP on all bridges by default.
    Enabling STP can lead to port down event if BPDU guard is enabled
    on the switch.

    Closes-Bug: #2028775

    Change-Id: I35eaa92f4243af00697306aa801e5a733885ce4f
    (cherry picked from commit f1fd127c34f07624b472e07c3e589080499b29dd)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/891754
Committed: https://opendev.org/openstack/kayobe/commit/b0f5e013a6e2b58ec486bf8a2481624b2ac7299e
Submitter: "Zuul (22348)"
Branch: stable/zed

commit b0f5e013a6e2b58ec486bf8a2481624b2ac7299e
Author: Bartosz Bezak <email address hidden>
Date: Thu Jul 27 13:11:12 2023 +0000

    Add STP option for bridge interfaces

    For Rocky Linux 9, Kayobe will now disable STP on a bridge by default,
    to preserve compatibility with network scripts, as Network Manager
    enables STP on all bridges by default.
    Enabling STP can lead to port down event if BPDU guard is enabled
    on the switch.

    Closes-Bug: #2028775

    Change-Id: I35eaa92f4243af00697306aa801e5a733885ce4f
    (cherry picked from commit f1fd127c34f07624b472e07c3e589080499b29dd)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/891755
Committed: https://opendev.org/openstack/kayobe/commit/967c4beff86689faba679f55255f92d23505ced1
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 967c4beff86689faba679f55255f92d23505ced1
Author: Bartosz Bezak <email address hidden>
Date: Thu Jul 27 13:11:12 2023 +0000

    Add STP option for bridge interfaces

    For Rocky Linux 9, Kayobe will now disable STP on a bridge by default,
    to preserve compatibility with network scripts, as Network Manager
    enables STP on all bridges by default.
    Enabling STP can lead to port down event if BPDU guard is enabled
    on the switch.

    For CentOS Stream 8 and Rocky Linux 8 enabling STP is not supported.

    Closes-Bug: #2028775

    Change-Id: I35eaa92f4243af00697306aa801e5a733885ce4f
    (cherry picked from commit f1fd127c34f07624b472e07c3e589080499b29dd)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.