Juniper Openstack

config: persist ip value to zookeeper only in request context (i.e avoid in notify contexts).

  1. Series trunk
  2. Bug #1442404
Bug #1442404 reported by Hampapur Ajay
30
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R2.21.x
Fix Committed
Undecided
Hampapur Ajay
Juniper Openstack r2.21.4
Trunk
Fix Committed
Undecided
Hampapur Ajay
Juniper Openstack r3.0-fcs

Bug Description

Currently when an ip address is allocated, it is set-aside in 2 places
1. in local memory bitmap
2. in zookeeper for owning this bucket

These operation happens in both request and notify contexts. Ideally 1. and 2. should happen in request context and only 2. should happen in notify context.

Hampapur Ajay (hajay)
Changed in juniperopenstack:
assignee: nobody → Hampapur Ajay (hajay)
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : master

Review in progress for https://review.opencontrail.org/9036
Submitter: Hampapur Ajay (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/9036
Committed: http://github.org/Juniper/contrail-controller/commit/b9b9e4258847840351eb2b2d432637d8cd96736b
Submitter: Zuul
Branch: master

commit b9b9e4258847840351eb2b2d432637d8cd96736b
Author: Hampapur Ajay <email address hidden>
Date: Thu Apr 9 16:09:06 2015 -0700

config: Persist ip value to zk only in request context.

Also store the uuid of the object in zk for tracking purpose.
On port-update with fixed-ips in body, only create iip for
new ips. Earlier implementation would reserve same ip twice
(new iip created before deleted).

Change-Id: I53ce79ccb2359502015584ad6f13b886715ff2a6
Closes-Bug: #1442404

Changed in juniperopenstack:
status: New → Fix Committed
Revision history for this message
Daisuke Nakajima (dnakajima) wrote :

Could you merge fixed code to R2.20 trunk?

Ashish Ranjan (aranjan-n)
Changed in juniperopenstack:
milestone: none → r2.30-fcs
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22-dev

Review in progress for https://review.opencontrail.org/13804
Submitter: Atul Moghe (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/13804
Committed: http://github.org/Juniper/contrail-controller/commit/f82c19b05a9bc34b01b7287a3efe04b9974cb71f
Submitter: Zuul
Branch: R2.22-dev

commit f82c19b05a9bc34b01b7287a3efe04b9974cb71f
Author: Hampapur Ajay <email address hidden>
Date: Thu Apr 9 16:09:06 2015 -0700

config: Persist ip value to zk only in request context.

Also store the uuid of the object in zk for tracking purpose.
On port-update with fixed-ips in body, only create iip for
new ips. Earlier implementation would reserve same ip twice
(new iip created before deleted).

Change-Id: I53ce79ccb2359502015584ad6f13b886715ff2a6
Closes-Bug: #1442404
(cherry picked from commit b9b9e4258847840351eb2b2d432637d8cd96736b)

Revision history for this message
Ashish Ranjan (aranjan-n) wrote :

The fix in 2.22-dev will not get merged in 2.20 automatically. Removed 2.20 scope for now.

no longer affects: juniperopenstack/r2.20
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.21.x

Review in progress for https://review.opencontrail.org/27177
Submitter: Jean-Philippe Braun (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/41974
Submitter: Suresh Vinapamula (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/41974
Committed: http://github.com/Juniper/contrail-controller/commit/54f7c5fa69f6c45bf02acc615fd76f549ce3c05d
Submitter: Zuul (<email address hidden>)
Branch: R2.21.x

commit 54f7c5fa69f6c45bf02acc615fd76f549ce3c05d
Author: Suresh Venkata <email address hidden>
Date: Mon Apr 16 12:21:34 2018 -0700

config: Persist ip value to zk only in request context.

Also store the uuid of the object in zk for tracking purpose.
On port-update with fixed-ips in body, only create iip for
new ips. Earlier implementation would reserve same ip twice
(new iip created before deleted).

Closes-Bug: #1442404
(cherry picked from commit b9b9e4258847840351eb2b2d432637d8cd96736b)
(cherry picked from commit f82c19b05a9bc34b01b7287a3efe04b9974cb71f)

Change-Id: I92b8d2fa3a1224e299ed575559c8fdb660b5ea4e

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.