Comment 2 for bug 1735112

Revision history for this message
John A Meinel (jameinel) wrote :

This looks to have been introduced by Tim's recent test suite around "juju show-status-log".
We are patching "time.Local" to force the test suite to give times in UTC time, but it appears to be racing with something else.
Previous read at 0x00000317e500 by goroutine 36:
  time.Now()
      /snap/go/1016/src/time/time.go:1049 +0xd3
  time.sendTime()
      /snap/go/1016/src/time/sleep.go:139 +0x44

is racing with:
  github.com/juju/testing.(*CleanupSuite).PatchValue()
      /home/jameinel/dev/go/src/github.com/juju/testing/cleanup.go:125 +0x5a
  github.com/juju/juju/cmd/juju/status_test.(*StatusHistorySuite).SetUpTest()
      /home/jameinel/dev/go/src/github.com/juju/juju/cmd/juju/status/history_test.go:34 +0x1b1

Probably the goroutine that is monitoring the time to see if it needs to kill the test suite because we went over time.
We probably can't fix that race, so we should see if we can avoid patching Local.