Comment 0 for bug 1517611

Revision history for this message
Curtis Hovey (sinzui) wrote : TestFilesystemInfo race condition in 1.25

As seen in
    http://reports.vapour.ws/releases/issue/559a68b2749a562e2e8bcd6b

TestFilesystemInfo can fail for hilarious reasons:

storage_test.go:187:
    c.Assert(info, jc.DeepEquals, expect)
... obtained state.FilesystemAttachmentInfo = state.FilesystemAttachmentInfo{MountPoint:"", ReadOnly:true}
... expected state.FilesystemAttachmentInfo = state.FilesystemAttachmentInfo{MountPoint:"", ReadOnly:true}
... mismatch at .ReadOnly: unequal; obtained true; expected true

mgz believes at the time of evaluation the value was false, but by the time of printing, the value is true.

This issue first appeared in 1.25
    https://github.com/juju/juju/commit/9c086f523c4c71300ce4f260f48bd7267d422c91

CI will try to make this test pass 3 times, then curse the branch. We have seen that with 6 tries the test can pass.