Comment 3 for bug 1229309
Revision history for this message
| Sergio Schvezov (sergiusens) wrote Re: [Bug 1229309] [NEW] No way to land a series of branches at once | #3 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
5c6b958
demo site
(Get the code!)
On Mon, Sep 23, 2013 at 3:44 PM, Aaron Bentley
<email address hidden>wrote:
> On 13-09-23 02:14 PM, Sergio Schvezov wrote:
> > If it really isn't a prereq I think it just shouldn't be listed as one.
>
> The landing of the first branch isn't a prerequisite, but the *review*
> of the first branch is. Because the second branch contains all the
> changes in the first branch, landing the second branch has the effect of
> landing the first. But this means that the first branch must be ready
> to land before the second branch can be landed.
>
This makes a lot of sense.
Marking the first branch as a prerequisite signals to Launchpad that its
> changes should be omitted from the diff of the second. This removes
> redundancy from the diff, makes review clearer and the diff shorter.
> Without it, splitting a piece of work into two branches will rarely have
> the desired effect of dividing the work into digestible chunks.
>
So the jenkins launchpad plugin should look at this and only merge the
parent to these prereqs.
I have a side question, does launchpad figure this out and mark the other
branches as merged?