Page titles in preferences don't escape text for markup

Bug #1368375 reported by houz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Low
houz

Bug Description

The page titles of the preferences are using GTK markup to print them bold. This leads to errors when the strings contain unescaped ampersands or similar glyphs, like the German translation of "Pen" does.

The attached patch fixes that.

Tags: preferences ui
Revision history for this message
houz (houz) wrote :
description: updated
Revision history for this message
su_v (suv-lp) wrote :

Reproduced with 0.91pre2 r13551 on OS X 10.7.5:

Console message when opening the prefs pane for the pen tool (LANG="de_DE.UTF-8"):

(inkscape:90993): Gtk-WARNING **: Failed to set text from markup due to error parsing markup: Fehler in Zeile 1: Entität endete nicht mit einem Semikolon; wahrscheinlich haben Sie ein &-Zeichen benutzt, ohne eine Entität beginnen zu wollen - umschreiben Sie das »&« als &

tags: added: preferences ui
Changed in inkscape:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
su_v (suv-lp) wrote :

Patch tested successfully with r13551 on OS X 10.7.5:

Affected translation strings for preferences pane headers (r13551):
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/view/13551/po/de.po#L16289>
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/view/13551/po/ko.po#L19133>

@JazzyNico - ok to commit?

Changed in inkscape:
assignee: nobody → houz (houz)
milestone: none → 0.91
status: Confirmed → In Progress
Revision history for this message
jazzynico (jazzynico) wrote :

Patch tested successfully on Crunchbang Waldorf, Inkscape trunk revision 13551, and committed revision 13552.
Thanks for the patch, houz!

Changed in inkscape:
status: In Progress → Fix Committed
Bryce Harrington (bryce)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.