HPLIP: `hp-check -r` incorrectly reports `libcupsimage` as not installed

Hi Paul,

This hp-check tool checks for the "/usr/include/cups/raster.h", if it is not found, then displays as libcupsimage is missing or incompatible message..

Provide us full hp-check or 'hp-check -r' output..

Thanks & Regards,
Amarnath

Dear Amarnath,

Am Donnerstag, den 18.10.2012, 08:33 +0000 schrieb Amarnath Chitumalla:

> This hp-check tool checks for the "/usr/include/cups/raster.h", if it is
> not found, then displays as libcupsimage is missing or incompatible
> message..

Why should a library ship a header file?

> Provide us full hp-check or 'hp-check -r' output..

Well, we already know what went wrong. Here is the package content in
Debian Sid/unstable.

        $ dpkg -L libcupsimage2
        /.
        /usr
        /usr/lib
        /usr/lib/i386-linux-gnu
        /usr/lib/i386-linux-gnu/libcupsimage.so.2
        /usr/share
        /usr/share/doc
        /usr/share/doc/libcupsimage2
        /usr/share/doc/libcupsimage2/changelog.gz
        /usr/share/doc/libcupsimage2/changelog.Debian.gz
        /usr/share/doc/libcupsimage2/copyright

For run time checks on distribution probably the package management
system should be consulted.

Thanks,

Paul

Dear Paul,

As you mentioned library doesn't provide header file.

"hp-check -r" check for cups-image packages (i.e. raster file), then this may be due to either libcupsimage2 or libcupsimage2-dev, so it displays both packages (i.e. libcupsimage2,libcupsimage2-dev) under this section (i.e. cups-image).

------conf fie----------------------------------------
[debian:x.x:cups-image]
packages=libcupsimage2,libcupsimage2-dev
----------------------------------------------

Thanks & Regards,
Amarnath

Dear Amarnath,

Am Donnerstag, den 18.10.2012, 09:43 +0000 schrieb Amarnath Chitumalla:

> As you mentioned library doesn't provide header file.

good. Will the check be changed to test for the actual library?

> "hp-check -r" check for cups-image packages (i.e. raster file),

Why does it need `raster.h`?

> then this may be due to either libcupsimage2 or libcupsimage2-dev, so it
> displays both packages (i.e. libcupsimage2,libcupsimage2-dev) under this
> section (i.e. cups-image).
>
> ------conf fie----------------------------------------
> [debian:x.x:cups-image]
> packages=libcupsimage2,libcupsimage2-dev
> ----------------------------------------------

It incorrectly lists one as missing!

        Missing Required Dependencies
        -----------------------------
        error: 'libcupsimage2' package is missing/incompatible
        error: 'libcupsimage2-dev' package is missing/incompatible
        error: 'libsnmp-dev' package is missing/incompatible

And two more packages as run-time dependencies although it should not
need any development files.

Here is the full output.

$ hp-check -r

HP Linux Imaging and Printing System (ver. 3.12.6)
Dependency/Version Check Utility ver. 15

Copyright (c) 2001-14 Hewlett-Packard Development Company, LP
This software comes with ABSOLUTELY NO WARRANTY.
This is free software, and you are welcome to distribute it
under certain conditions. See COPYING file for more details.

Note: hp-check can be run in three modes:
1. Compile-time check mode (-c or --compile): Use this mode before compiling the HPLIP supplied tarball (.tar.gz or .run) to determine if
the proper dependencies are installed to successfully compile HPLIP.
2. Run-time check mode (-r or --run): Use this mode to determine if a distro supplied package (.deb, .rpm, etc) or an already built HPLIP
supplied tarball has the proper dependencies installed to successfully run.
3. Both compile- and run-time check mode (-b or --both) (Default): This mode will check both of the above cases (both compile- and run-time
dependencies).

Check types:
a. EXTERNALDEP - External Dependencies
b. GENERALDEP - General Dependencies (required both at compile and run time)
c. COMPILEDEP - Compile time Dependencies
d. [All are run-time checks]
PYEXT SCANCONF QUEUES PERMISSION

Status Types:
    OK
   ...

Just install libcupsimage2-dev - worked for me.
apt-get install libcupsimage2-dev

Am Montag, den 18.02.2013, 08:35 +0000 schrieb Ad Aerts:
> Just install libcupsimage2-dev - worked for me.
> apt-get install libcupsimage2-dev

Please read the discussion above! It is not reasonable to check for a
header file.

So your solution is just a hack to silence the (wrong) warning instead
of a fix. Please implement a real fix.

Hi Paul,

Thank you for the information.
As per current HPLIP implementation, checks for both library and dev packages.
We will fix this in next build to check library package only.

Thanks & Regards,
Amarnath

The bug is that cups-image is incorrectly marked as GENERALDEP instead of COMPILEDEP in core_installer.py. Note that it is already marked DEPENDENCY_COMPILE_TIME in field 3. Unfortunately that field is totally ignored in hplip (i.e. it is ripe for removal).

See the attached patch for a fix.

I updated my patch on GitHub:
https://github.com/fgouget/hplip/commit/c3acb017905d1afa2dd15931b4a22a2bcc018634

Is this the right place to submit HPLIP patches?