[UIFe][FFe] add previews for Gwibber lens
Bug #1049127 reported by
Ken VanDine
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Gwibber |
Fix Committed
|
Medium
|
Unassigned | ||
Unity |
Fix Released
|
Undecided
|
Ken VanDine | ||
libunity |
Fix Released
|
Medium
|
Unassigned | ||
gwibber (Ubuntu) |
Fix Released
|
Medium
|
Ken VanDine | ||
Quantal |
Fix Released
|
Medium
|
Ken VanDine | ||
libunity (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Quantal |
Fix Released
|
Medium
|
Unassigned | ||
ubuntu-docs (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Quantal |
Invalid
|
Undecided
|
Unassigned | ||
unity (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Quantal |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Now that Unity supports previews, we want to make the gwibber lens more useful by utilizing previews. This has been a long time goal and would improve the experience with the lens.
This also provides a great way to show case the Ubuntu Online Accounts integration in the desktop, which is a key deliverable for 12.10.
Related branches
lp://staging/~ken-vandine/unity/6_with_social_preview
- Neil J. Patel (community): Approve
-
Diff: 1880 lines (+1712/-0)17 files modifiedUnityCore/CMakeLists.txt (+2/-0)
UnityCore/Preview.cpp (+5/-0)
UnityCore/SocialPreview.cpp (+105/-0)
UnityCore/SocialPreview.h (+77/-0)
dash/previews/CMakeLists.txt (+10/-0)
dash/previews/Preview.cpp (+5/-0)
dash/previews/SocialPreview.cpp (+305/-0)
dash/previews/SocialPreview.h (+93/-0)
dash/previews/SocialPreviewComments.cpp (+193/-0)
dash/previews/SocialPreviewComments.h (+78/-0)
dash/previews/SocialPreviewContent.cpp (+325/-0)
dash/previews/SocialPreviewContent.h (+86/-0)
dash/previews/StandaloneSocialPreview.cpp (+287/-0)
tests/CMakeLists.txt (+4/-0)
tests/test_previews_social.cpp (+110/-0)
unity-shared/PreviewStyle.cpp (+15/-0)
unity-shared/PreviewStyle.h (+12/-0)
lp://staging/~ken-vandine/unity/trunk_with_social_preview
- Neil J. Patel (community): Approve
-
Diff: 1884 lines (+1716/-0)17 files modifiedUnityCore/CMakeLists.txt (+2/-0)
UnityCore/Preview.cpp (+5/-0)
UnityCore/SocialPreview.cpp (+105/-0)
UnityCore/SocialPreview.h (+77/-0)
dash/previews/CMakeLists.txt (+10/-0)
dash/previews/Preview.cpp (+5/-0)
dash/previews/SocialPreview.cpp (+309/-0)
dash/previews/SocialPreview.h (+93/-0)
dash/previews/SocialPreviewComments.cpp (+193/-0)
dash/previews/SocialPreviewComments.h (+78/-0)
dash/previews/SocialPreviewContent.cpp (+325/-0)
dash/previews/SocialPreviewContent.h (+86/-0)
dash/previews/StandaloneSocialPreview.cpp (+287/-0)
tests/CMakeLists.txt (+4/-0)
tests/test_previews_social.cpp (+110/-0)
unity-shared/PreviewStyle.cpp (+15/-0)
unity-shared/PreviewStyle.h (+12/-0)
lp://staging/~ken-vandine/libunity/social_preview
- Paweł Stołowski (community): Approve
-
Diff: 258 lines (+177/-4)4 files modifiedprotocol/protocol-previews.vala (+96/-0)
src/unity-previews.vala (+55/-0)
test/vala/test-previews.vala (+21/-0)
tools/preview-renderer.vala (+5/-4)
Changed in gwibber (Ubuntu): | |
milestone: | none → ubuntu-12.10-beta-2 |
Changed in libunity (Ubuntu): | |
milestone: | none → ubuntu-12.10-beta-2 |
Changed in unity (Ubuntu): | |
milestone: | none → ubuntu-12.10-beta-2 |
summary: |
- [FFe] add previews for Gwibber lens + [UIFe][FFe] add previews for Gwibber lens |
Changed in unity (Ubuntu Quantal): | |
status: | New → Triaged |
Changed in libunity (Ubuntu Quantal): | |
status: | New → Triaged |
Changed in gwibber (Ubuntu Quantal): | |
status: | New → Triaged |
Changed in unity: | |
status: | New → Fix Committed |
milestone: | none → 7.0 |
assignee: | nobody → Ken VanDine (ken-vandine) |
Changed in unity (Ubuntu Quantal): | |
importance: | Undecided → Medium |
Changed in libunity (Ubuntu Quantal): | |
importance: | Undecided → Medium |
Changed in gwibber (Ubuntu Quantal): | |
assignee: | nobody → Ken VanDine (ken-vandine) |
importance: | Undecided → Medium |
status: | Triaged → In Progress |
Changed in gwibber: | |
importance: | Undecided → Medium |
milestone: | none → 3.6 |
status: | New → Fix Committed |
no longer affects: | unity/6.0 |
Changed in unity: | |
milestone: | 7.0 → 6.6 |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Changed in libunity: | |
importance: | Undecided → Medium |
status: | New → Fix Released |
To post a comment you must log in.
Since this is going to impact the visible interfaces, a UIFe is needed here as well [1]. Please send email to the docs team including screen shots, and paste the link to the email in this bug.
What testing has been done to date on this? With it landing late what is the plan if there is a serious problem. Do we just disable it?
Can this feature be uploaded on its own? Would prefer it not to be combined with bug fixes, so we have an easy way of backing it out, if it proves problematic.
[1] https:/ /wiki.ubuntu. com/FreezeExcep tionProcess