Comment 3 for bug 1262380

Revision history for this message
Steve Langasek (vorlon) wrote : Re: [Bug 1262380] Re: gtk+3.0 FTBFS on ppc64el

On Thu, Dec 26, 2013 at 08:15:29AM -0000, Alan Modra wrote:
> I'm fairly certain this is a bug in the test itself.

> If you take a look at glib2.0/gobject/gmarshal.c g_cclosure_marshal_VOID__PARAM, you see
> typedef void (*GMarshalFunc_VOID__PARAM) (gpointer data1,
> gpointer arg_1,
> gpointer data2);

> That says to me that all of the signal functions in gtk/tests/builder.c should be declared as
> signal_normal (GtkWindow *window, GParamSpec *spec)
> not
> signal_normal (GtkWindow *window, GParamSpec spec)

> The "spec" parameter corresponds to "arg_1" in the typedef, which is a
> pointer.

Thanks Alan, confirmed here that fixing the prototypes of the signal
functions resolves the testsuite failure. I'm uploading gtk+3.0 to Ubuntu
now with this patch.