Comment 1 for bug 529919
Revision history for this message
| Lionel Dricot (ploum-deactivatedaccount) wrote | #1 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
9199653
demo site
(Get the code!)
This is a very interesting usecase. Your fix is good but, if we want to be really perfect, we should do it otherwise.
In fact, the TaskEditor should catch the "task-deleted" signal from the requster and react by closing itself.
This has several advantages : TaskEditor is independant from the ViewManager and can be replaced by any TaskEditor module while, with your fix, we create a strong dependancy that the TaskEditor should always have a destroy function that does what it's expected it should be doing (and this is not always clear).
By reaction to the signal, you are taking your own responsibility, just like the browser is doing right now.
This is, in essence, the new philosophy I had when doing the refactoring. (I hope it will work but, to be honnest, I don't believe that connecting to the signal is harder than your fix)