Comment 80 for bug 1546507

Revision history for this message
Brian Rosmaita (brian-rosmaita) wrote :

Tomoki, a few comments about your patch. These might all be OK, just some things I noticed.

(1) previously, if _check_context() raised glance_store.exceptions.BadStoreConfiguration, the code caught it, logged it, and get_size() returned 0. The patch doesn't catch this exception any more.

(2) the patch raises glance_store.exceptions.BackendException -- I'm worried that this is going to be a 500 somewhere up the call chain (which is better than allowing a security exploit, but something that translated to a 403 might be nicer?) I haven't done much work on glance_store, so if the BackendException is more consistent with what the other drivers do, that's fine -- just thought I'd ask.