Reviewed: https://review.openstack.org/187292 Committed: https://git.openstack.org/cgit/openstack/neutron-lbaas/commit/?id=52d40851418db73cde4d9459637de69797ba2bd4 Submitter: Jenkins Branch: master
commit 52d40851418db73cde4d9459637de69797ba2bd4 Author: Cedric Brandily <email address hidden> Date: Mon Jun 1 21:06:46 2015 +0200
Do not assume http expected_codes ordering
This fixes the unit tests[1] that breaks with a randomized PYTHONHASHSEED (see the bug report).
The test assumed that expected_codes had elements in particular order. Found with PYTHONHASHSEED=1.
The fix refactors the test case by injecting values using the same ordering.
[1] neutron_lbaas.tests.unit.services.loadbalancer.drivers.haproxy.\ test_jinja_cfg
Partial-bug: #1348818
Note: There are several other unrelated unit tests that also break with a randomized PYTHONHASHSEED, but they are not addressed here. They will be addressed in separate patches.
Change-Id: I5d761c392bf37a0b3626abc64e0e428f978638df
Reviewed: https:/ /review. openstack. org/187292 /git.openstack. org/cgit/ openstack/ neutron- lbaas/commit/ ?id=52d40851418 db73cde4d945963 7de69797ba2bd4
Committed: https:/
Submitter: Jenkins
Branch: master
commit 52d40851418db73 cde4d9459637de6 9797ba2bd4
Author: Cedric Brandily <email address hidden>
Date: Mon Jun 1 21:06:46 2015 +0200
Do not assume http expected_codes ordering
This fixes the unit tests[1] that breaks with a randomized
PYTHONHASHSEED (see the bug report).
The test assumed that expected_codes had elements in particular order.
Found with PYTHONHASHSEED=1.
The fix refactors the test case by injecting values using the same
ordering.
[1] neutron_ lbaas.tests. unit.services. loadbalancer. drivers. haproxy. \
test_jinja_ cfg
Partial-bug: #1348818
Note: There are several other unrelated unit tests that also break with
a randomized PYTHONHASHSEED, but they are not addressed here. They will
be addressed in separate patches.
Change-Id: I5d761c392bf37a 0b3626abc64e0e4 28f978638df