Comment 18 for bug 1190149

Revision history for this message
Florent Flament (florentflament) wrote :

An interesting comment from Mark McClain about redefining constants:
https://review.openstack.org/#/c/56511/2/neutron/wsgi.py

I agree with him that redefining constants should be avoided when possible, since it can possibly create unexpected behaviors if the constant is redefined to different values in different parts of the code.

However, in the case of the eventlet.wsgi.MAX_HEADER_LINE constant, I don't see any better solution until eventlet's code is updated:
https://bitbucket.org/eventlet/eventlet/src/66cc547edabfb7b45afaead69f029cae7f51f161/eventlet/wsgi.py#cl-189

We should be careful about not redefining this constant several times (grep -r MAX_HEADER_LINE .)