Glance

  1. Series essex
  2. Bug #1098962
  3. Comment #10

Comment 10 for bug 1098962

Revision history for this message
Iccha Sethi (iccha-sethi) wrote : Re: glance image-download can display backend Swift password

Thanks for pointing that out Dan. I was combing through the swift code in glance/store and found a couple of other places where we display the uri in exceptions and logs. It may be good to sanitize them all(esp the exception). Will list them below.

139 LOG.debug(_("Invalid store uri %(uri)s: %(reason)s") % locals())

183 except IndexError:
184 reason = _("Badly formed Swift URI: %s") % uri
185 LOG.debug(reason)

375 except swiftclient.ClientException, e:
376 if e.http_status == httplib.CONFLICT:
377 raise exception.Duplicate(_("Swift already has an image at "
378 "location %s") %
379 location.get_uri())