functional test broken

Bug #1745003 reported by Brian Rosmaita
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Triaged
Critical
Brian Rosmaita

Bug Description

This started failing in the gate today:

 ==============================
 Failed 1 tests - output below:
 ==============================

 glance.tests.functional.db.migrations.test_ocata_migrate01.TestOcataMigrate01MySQL.test_walk_versions
 -----------------------------------------------------------------------------------------------------

 Captured traceback:
 ~~~~~~~~~~~~~~~~~~~
     b'Traceback (most recent call last):'
     b' File "/home/zuul/src/git.openstack.org/openstack/glance/glance/tests/functional/db/test_migrations.py", line 63, in test_walk_versions'
     b' with_data=True)'
     b' File "/home/zuul/src/git.openstack.org/openstack/glance/glance/tests/functional/db/test_migrations.py", line 57, in _migrate_up'
     b' check(engine, data)'
     b' File "/home/zuul/src/git.openstack.org/openstack/glance/glance/tests/functional/db/migrations/test_ocata_migrate01.py", line 133, in _check_ocata_expand01'
     b" self.assertEqual('private', rows[0]['visibility'])"
     b' File "/home/zuul/src/git.openstack.org/openstack/glance/.tox/py35/lib/python3.5/site-packages/testtools/testcase.py", line 411, in assertEqual'
     b' self.assertThat(observed, matcher, message)'
     b' File "/home/zuul/src/git.openstack.org/openstack/glance/.tox/py35/lib/python3.5/site-packages/testtools/testcase.py", line 498, in assertThat'
     b' raise mismatch_error'
     b"testtools.matchers._impl.MismatchError: 'private' != None"
     b''

I have not been able to reproduce locally (yet). This is from the zuul_info from a failing test:

Image Information
=================

/etc/dib-builddate.txt
----------------------
2018-01-22 21:42

/etc/image-hostname.txt
-----------------------
ubuntu-xenial

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to glance (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/536939

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to glance (master)

Reviewed: https://review.openstack.org/536939
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=5517049c0f40e930361ad9a77d15b708a919fcb6
Submitter: Zuul
Branch: master

commit 5517049c0f40e930361ad9a77d15b708a919fcb6
Author: Brian Rosmaita <email address hidden>
Date: Tue Jan 23 14:31:50 2018 -0500

    Skip one functional test

    Skip this test until Bug #1745003 is fixed.

    Change-Id: I725c228b82efd408b283854c1be2d1bdab33a834
    Related-bug: #1745003

Revision history for this message
Brian Rosmaita (brian-rosmaita) wrote :

Also happening under py27, now that those tests are no longer blocked by the eventlet issue.

Changed in glance:
importance: Undecided → Critical
assignee: nobody → Brian Rosmaita (brian-rosmaita)
summary: - functional test broken under py35
+ functional test broken
Revision history for this message
Brian Rosmaita (brian-rosmaita) wrote :

Update: still not sure why it only started failing recently, but here's some more info:

- it fails for both py27 and py35

- postgresql wasn't being tested for migrations; when I added postgres, it failed too

- it fails at the first check to see if the 'visibility' has been migrated correctly; when that's commented out, it then fails at the next, and so on. All the values for 'visibility' appear to be None

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to glance (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/538694

Changed in glance:
milestone: queens-3 → queens-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to glance (master)

Reviewed: https://review.openstack.org/538694
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=9363e0b0a14acf0ed9abc0e5d1f939131655ae03
Submitter: Zuul
Branch: master

commit 9363e0b0a14acf0ed9abc0e5d1f939131655ae03
Author: Brian Rosmaita <email address hidden>
Date: Sun Jan 28 18:31:02 2018 -0500

    Skip one functional test

    Skip this test until Bug #1745003 is fixed. It's not a normal
    skip; the skipping is done by commenting out the offending
    assertions. That's because I725c228b82efd408b283854c1be2d1bdab33a834
    appears to be completely ineffective, probably because of the
    mixins used in the db functional tests.

    Change-Id: I01bc954fc524d64cfeae67f8d03fe15f998893e6
    Related-bug: #1745003

Changed in glance:
milestone: queens-rc1 → rocky-1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.