Glance

  1. Bug #1245775
  2. Comment #6

Comment 6 for bug 1245775

Revision history for this message
Amala Basha (amalabasha) wrote : Re: safe_delete_from_backend does not raise a "not found " exception

Your concern is perfectly valid. From the code, this safe_delete_from_backend seems to be called in upload_utils while an update_to_store happens and a mismatch or something requires a deletion. This seems to be fine, but safe_delete is also called during a normal controller delete as well. In such a scenario, I dont really think swallowing an exception is a good idea. Either we should change this bit of code to call delete_from_backend or just raise the appropriate exception here. Thoughts?