Comment 15 for bug 699454

Dear nobody,

Thank you for your interest in this patch. once it was useful for me
and I want it to be as best as possible.

> Looks like some good features, although it does potentially increase the
> number of ways to get gerber output wrong for the user!

If the code is correct, it produces valid output only.

> Perhaps we should add some default button to the exporter which greys out
> the other options, and retains PCB's old ways for exporting.

Isn't it really enough that the default settings result in the output
identical to the output of the unpatched version? (actually there no
buttons in command line)

Frankly speaking, I just don't imagine neither what it
might look like to be convenient for users,
nor what work it will get.

> Now we're using GIT, it should be really easy to produce a rebased patch
> series for these changes, complete with log entries

Agreed, it should.

> (no /*... */ history comments in the code please!)

I still believe it is a formal requirement of the GNU GPL
for the contributor. It does not take too much time for
a developer to delete them, e.g. via requesting the
contributor; and if it is not a mainstream version,
these comments don't harm, do they?

> Looking at the code, and the list of features added, I think this could
> sensibly be more than one patch.

Yes, it could.

> Refactor output precision code,

I shall try.

> Add externally visible options for adjusting the output precision

To force invalid output? whoever is _that_ special,
this person certainly knows it can easily be made
with sed postprocessing.

I don't refuse, I just need a reason to know
how to implement it properly.

> Option to add outline to all layers
> "disable drills output in outline layers" (Isn't this was already done?)

"disable drills.." was a bug in earlier versions of the patch;
"outline all layers" had not been done yet when I posted it;
IIRC it was synchronised with mainstream in the latest patch version.

> I've never personally come across any requirement to have X and Y axis
> resolutions different in the gerber file. I'm not sure it is a useful
> option to export

I had never personally come across any requirement to have any
of these features until Oct 2008. I just read the specification and tried
to provide more flexibility.

Thank you again for your comments. they are really constructive.