restore session by default
Bug #1232112 reported by
Danielle Foré
This bug affects 11 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Calculator |
Fix Released
|
Low
|
Marvin Beckers | ||
Files |
Fix Released
|
Medium
|
Jeremy Wootten | ||
Geary |
Confirmed
|
Undecided
|
Unassigned | ||
Maya |
Fix Released
|
Medium
|
Corentin Noël | ||
Scratch |
Fix Released
|
Low
|
Mario Guerriero |
Bug Description
For Freya, we should try to make sure that every app we ship restores the previous session by default. This will be our second release with no minimize button and we really need to make sure that it works as advertised.
Related branches
lp://staging/~mefrio-g/scratch/fix-1232112
- Victor Martinez (community): Approve
-
Diff: 147 lines (+62/-9)3 files modifiedschemas/org.pantheon.scratch.gschema.xml (+27/-1)
src/MainWindow.vala (+27/-6)
src/Services/Settings.vala (+8/-2)
lp://staging/~jeremywootten/pantheon-files/restore-state
- Cody Garver (community): Approve
-
Diff: 1299 lines (+348/-174)17 files modifiedlibcore/gof-directory-async.vala (+21/-25)
libcore/gof-file.c (+3/-3)
libwidgets/Animations.vala (+2/-2)
libwidgets/BreadcrumbsElements.vala (+2/-2)
libwidgets/LocationBar.vala (+53/-33)
schemas/org.pantheon.files.gschema.xml (+15/-0)
src/Application.vala (+9/-8)
src/View/LocationBar.vala (+5/-2)
src/View/ViewContainer.vala (+33/-12)
src/View/Window.vala (+127/-18)
src/fm-abstract-icon-view.c (+2/-2)
src/fm-columns-view.c (+6/-6)
src/fm-directory-view.c (+17/-21)
src/gof-window-slot.c (+13/-24)
src/marlin-window-columns.c (+34/-14)
src/marlin-window-columns.h (+2/-2)
src/marlin.vapi (+4/-0)
lp://staging/~codygarver/scratch/fix-1232112
- Cody Garver (community): Approve
-
Diff: 19 lines (+2/-2)1 file modifiedschemas/org.pantheon.scratch.gschema.xml (+2/-2)
lp://staging/~embik/pantheon-calculator/gsettings
- Cody Garver (community): Approve
-
Diff: 106 lines (+40/-4)3 files modifiedCMakeLists.txt (+3/-0)
data/org.pantheon.calculator.gschema.xml (+20/-0)
src/MainWindow.vala (+17/-4)
Changed in switchboard: | |
status: | New → Incomplete |
Changed in pantheon-files: | |
importance: | Undecided → Medium |
status: | New → Confirmed |
milestone: | none → isis-beta1 |
Changed in maya: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
milestone: | none → isis-beta1 |
Changed in scratch: | |
status: | New → Confirmed |
importance: | Undecided → Low |
milestone: | none → isis-beta1 |
Changed in scratch: | |
assignee: | nobody → Mario Guerriero (mefrio-g) |
status: | Confirmed → In Progress |
Changed in scratch: | |
status: | In Progress → Fix Released |
Changed in maya: | |
status: | Confirmed → Fix Committed |
assignee: | nobody → Corentin Noël (tintou) |
Changed in switchboard: | |
importance: | Undecided → Medium |
milestone: | none → isis-beta1 |
Changed in pantheon-files: | |
assignee: | nobody → Jeremy Wootten (jeremywootten) |
Changed in pantheon-files: | |
status: | Confirmed → In Progress |
Changed in pantheon-files: | |
status: | In Progress → Fix Committed |
Changed in switchboard: | |
milestone: | isis-beta1 → isis-beta2 |
Changed in maya: | |
status: | Fix Committed → Fix Released |
Changed in switchboard: | |
milestone: | freya-beta2 → none |
description: | updated |
Changed in pantheon-files: | |
status: | Fix Committed → Fix Released |
Changed in pantheon-calculator: | |
assignee: | nobody → Marvin Beckers (embik) |
importance: | Undecided → Low |
status: | New → In Progress |
Changed in pantheon-calculator: | |
status: | In Progress → Fix Committed |
milestone: | none → freya-beta2 |
Changed in pantheon-calculator: | |
status: | Fix Committed → Fix Released |
no longer affects: | switchboard |
To post a comment you must log in.
FYI there's an already-in-place mechanism in Glib.Application and therefore Granite.Application to fully save a state of an application and restore it later. This can be triggered by e.g. D-bus signal via the Glib.Application D-bus interfaces provided by any of our apps.
This is a very tempting shortcut at first glance. However, it might save the state a bit too fully - it serializes everything up to the the widget states and restores everything later, by which time the environment may have drastically changed and the saved state is no longer relevant.
It might prove useful, but has to be thoroughly investigated and used with care.