in functions/product.sh in function enable_outbound_network_for_product_vm() we call ping utility with '-c' argument.
Unfortunately in CYGWIN it runs windows version of ping utility and there is no '-c' argument.
Steps to reproduce:
1. get windows
2. install cygwin with default packages
3. download and unpack vbox scripts.
4. put MirantisOpenStack-5.1.iso in it's iso directory.
5. run launch.sh in CYGWIN console and wait until MOS installation finish.
6. put '-x' into shebang line in actions/master-node-enable-internet.sh script to enable debug output.
6. run actions/master-node-enable-internet.sh in CYGWIN console
Expected result:
script run ping utility to check for internet connectivity on the host system. And ping should run normally and return true or false depending on internet connectivity.
Actual result:
Ping utility fails with error "Bad option -c" but returns 0 therefore script always decides there is internet connectivity.
Workaround:
Add case-esac part into enable_outbound_network_for_product_vm() function:
# Check for internet access on the host system
echo -n "Checking for internet connectivity on the host system... "
case "$(uname)" in
CYGWIN*)
ping_count_opt="-n"
;;
*)
ping_count_opt="-c"
;;
esac
if [ "`ping ${ping_count_opt} 5 google.com || ping ${ping_count_opt} 5 wikipedia.com`" ]; then
echo "OK"
else
echo "FAIL"
print_no_internet_connectivity_banner
return 1
fi
Fix proposed to branch: master
Review: https:/