Mozilla Firefox

  1. Bug #206191
  2. Comment #38

Comment 38 for bug 206191

Revision history for this message
In , Gavin Sharp (gavin-sharp) wrote :

Comment on attachment 312156
Updated to check GTK+ version

>diff -up mozilla/browser/components/shell/src/nsGNOMEShellService.cpp.gconf mozilla/browser/components/shell/src/nsGNOMEShellService.cpp

>+ColorToCString(PRUint32 aColor, nsCString& aResult)

>+ gchar *colorString = gdk_color_to_string(&color);
>+ aResult.Adopt(colorString);
>+ g_free(colorString);

Shouldn't you copy the string here?

Looks fine otherwise. Make sure to land the test too?