Comment 0 for bug 128062

Revision history for this message
In , Philip-chee (philip-chee) wrote :

Error: [JavaScript Error: "Bad NPObject as private data!" {file:
"chrome://flashblock/content/flashblock.xml" line: 190}]
Source File: chrome://flashblock/content/flashblock.xml
Line: 190

The Flashblock extension triggers a bug in the plugin code when flashplayer 8
plugin is installed. This problem does not occur with flashplayer 7 is installed.

Problem appears in:
Firefox 1.0.6,
Firefox/1.4 (Gecko/20050917)
SeaMonkey/1.1a (Gecko/20050912)

Steps to reproduce:

1. Install flashplayer 8.0.22 from the Macromedia website.
   <http://www.macromedia.com/software/flashplayer/>
2. Install Flashblock 1.3.2 or later from:
   <http://flashblock.mozdev.org/installation.html>
3. Visit test case at:
   <http://bugzilla.mozdev.org/attachment.cgi?id=3443>
4. Click on flashblock placeholder to reveal flash.

Expected results: Flash is shown.

Actual results: Flashblock placeholder remains in place.
Error shows up in the javascript console.

We add a custom attribute "prevHeight" to the html flash element before removing
it from the DOM. When we restore the element we check for the existence of this
attribute and we are failing on this line:

if("prevHeight" in current) {

I tried using a try/catch block but for some reason the try/catch was not
catching this error.

current.prevHeight
current.getAttribute("prevHeight")

also cause this error.

Even if the bug is with the macromedia flash plugin, try/catch should have
caught it but doesn't.

Possibly related bug 308814