Comment 9 for bug 1721131

Maybe I am misunderstanding something here, but if we make the decision to revert back to the most recent sticky settings, doesn't that completely defeat the purpose of the "Clear Form" button?

As a test, (the patch isn't needed for this test)...

1. Open up Patron Search and set Search OU to CONS.
2. In a new tab, go to Workstation>Stored Preferences>In-Browser Prefs.
3. Find "eg.circ.patron.search.ou" and confirm the value is set to '1' (or whatever org you selected above).
4. Return to the Patron Search tab. Set Search OU to another option, (i.e. BR1). You don't even need to perform a search. Just choose a branch from the dropdown.
5. Return to the Preferences tab. Refresh the page. Return to "eg.circ.patron.search.ou". Confirm the value is set to the new org unit ID.

A similar process can be done for "eg.circ.patron.search.include_inactive", which lives under Server Workstation Prefs on my system.

If the "Clear Form" button reverted to the sticky search_ou session, then nothing would change, correct? Because the setting is already set to whatever branch you just filtered on?

I would be in favor of the "Clear Form" button reverting search to the broadest terms possible - CONS and include inactive, (or perhaps retaining the sticky setting for inactive).

In my testing on both Evergreen 3.2.10ish and 3.5ish, if you refresh the page, the search form reverts all manually entered terms as well as Profile Group. If staff want to keep their sticky OU and inactive settings, they could simply refresh the page to achieve it.

The only time I personally feel a need to use the "Clear Form" button is when I need to clear fields that are not cleared on a refresh.