Comment 1 for bug 1685840

Revision history for this message
Dan Scott (denials) wrote :

See http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbs/lp1685840_dojoless_google_books for a series of patches that:

a) reworks the core JavaScript to require only vanilla JavaScript, and to avoid polluting the global namespace in the process
b) uses EventListeners instead of href=javascript: links
c) avoids loading the Google Books preview JSAPI unless a matching ISBN is found in the Google Books volume API
d) modifies display style directly rather than abstracting it behind hideMe()/unHideMe()
e) uses the viewport's actual dimensions as reported by the browser rather than hardcoding a 600x800 view of the book
f) uses JavaScript to determine the language in which the preview should be displayed rather than having TT2 have to process the script
g) includes the script externally (enabling caching - note that we will want to add this to #1681095 "cache-busting" if that enhancement ends up getting merged) rather than inlining it into each /eg/opac/record page