Comment 90 for bug 1198465

Revision history for this message
Dan Wells (dbw2) wrote :

Okay all, pushed a couple more commits for the testing work Remington and I (mostly Remington) have been done (so far) out to the current branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/lp1198465_cond_neg_bal_rebase_20150529

working/user/dbwells/lp1198465_cond_neg_bal_rebase_20150529

This work-in-progress for testing the conditional covers 9 of the 14 test cases listed here (as of today):

http://evergreen-ils.org/dokuwiki/doku.php?id=qa:billing_test_cases

NOTES AND TODOS:
- The test is currently an SQL setup file plus a Perl live test file. You must first load/run the SQL, then the Perl live test. One simple improvement would be to ditch the SQL file and switch the setup process to cstore calls within the Perl test file. This would be both more contained and more robust.
- A second step to more advanced and useful tests would be to use higher-level API calls to create portions of the setup rather than doing everything manually. However, some test conditions cannot be reasonably setup with the higher-level API calls (e.g. bills of a specific age, or bills using a legacy format no longer generated by current code), so certain areas will likely always require direct manipulation.

We plan to keep pushing to get the rest of the tests in, which should go more smoothly now. Improving the tests as explained above will be a secondary priority.

Feedback welcome!

Sincerely,
Dan