Comment 84 for bug 1198465

Okay, two things.

First, I have a fix for the situation reported in comment #83. From the commit:

LP 1198465: Set restored overdue timestamp to time of last overdue
When we have our settings configured to generate new overdues on lost
item return, we start generation after the most recent overdue fine.
Because of this, we need the restored fine to be dated in the past,
which in turn allows the fine generator to apply catch-up fines as
expected.

You can find that commit, plus one more to clean up some variable names, key names, and comments, in a rebased branch here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/lp1198465_cond_neg_bal_rebase_20150529

BUT...

The second thing I want to say is that I plan to attempt to significantly simplify this branch. Having lived with this code through various mutations over the years, I feel perhaps we're being more heavy-handed than we really need to be to accomplish the stated goals. Remington and I are both setting aside time to work out a comprehensive set of tests (we have one working so far, woot!), and I am going to use those tests to experiment with trimming this code down to the bare essentials. Because of that, I am leaving this assigned to myself for now.

In the meantime, if anyone wants to take the last patches for a spin, please do. After all, there are no guarantees that simplification will work out, so it would be nice to have this current code "in our back pocket" when the time comes to make a move.