Comment 61 for bug 1198465

Revision history for this message
Dan Wells (dbw2) wrote :

Here is an update on progress made on this branch at and since the Hackaway in September.

First, it was determined that some of the "extra" fines were being caused by the way the system was generating fines retrospectively for lost items returned (whenever that option was enabled). Basically, those fines were being added in their own transaction *after* the circ had been otherwise processed, so the new code never saw them. During the Hackaway, Mike and Bill worked together to make a way to bring this fine generation step back into the normal order, which you can see here:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=e1fdcd3a6885baac3f86402e330aef3d8b36c681
and here:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=d2a521c0ff32e9921bfc93cb86b2c917e5eda92e

These commit were improvements no matter what else happens, so I have already signed-off and pushed them to master. With those in place, I have now force-pushed a rebased version of this bug's 6/18 branch to here:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/lp1198465-conditional-negative-balances

While I think this solves the biggest known processing issues, we still have problems with overall understandability of the interface. It isn't quite ready for testing yet, but as mentioned at the last dev meeting, I have two branches nearing test-worthiness which will do the following:
1) Adjust the bill dating logic to date bills at their inception rather than their conclusion. This is necessary to make a sensible timeline which includes both bills and payments. The code is finished from the fine generation angle, but still needs work to create an upgrade script.
2) With the first branch in place, alter the detailed bill display to combine bills, payments, and voids into a single timeline view.

My goal is to have these branches published by (American) Thanksgiving.