Comment 33 for bug 1198465

Following up on Tim's comment, I agree with his preference for a system where straight debits and credits are applied, which is why is another reason I'm partial to the void payment approach. I agree that the reports issue needs to be addressed, but maybe there's a way we can address that issue while keeping most of Jason's code in tact.

Nevertheless, I also asked Jason to load Dan's code on his server so that I can see how his approach in action. I've come across an error message through the following steps:

- I set the Prohibit negative balance on bills (Default) setting to True for my OU.
- I checked out an item on a patron's record and marked it as lost. The patron's account was billed $12.95 for the item.
- I applied a partial payment (3.01) for the item leaving a balance of $9.94
- I checked in the item. I receive an alert telling me the item is Lost and asking me if I want to override. I click "Yes" and get the following error messages. The item is not checked in and the $9.94 bill remains on the patron's account.

Network or server failure. Please check your Internet connection to jasondev.mvlcstaff.org and choose Retry Network. If you need to enter Offline Mode, choose Ignore Errors in this and subsequent dialogs. If you believe this error is due to a bug in Evergreen and not network problems, please contact your help desk or friendly Evergreen administrators, and give them this information:
method=open-ils.circ.checkin.override
params=["xxxx",{"barcode":"xxxxxxxxxxxxxx"}]
THROWN:
{"payload":[],"debug":"osrfMethodException : *** Call to [open-ils.circ.checkin.override] failed for session [1393943642.761727.139394364230049], thread trace [1]:\nCan't use an undefined value as an ARRAY reference at /usr/local/share/perl/5.14.2/OpenILS/Utils/CStoreEditor.pm line 575.\n\n","status":500}
STATUS:

and then:

Network or server failure. Please check your Internet connection to jasondev.mvlcstaff.org and choose Retry Network. If you need to enter Offline Mode, choose Ignore Errors in this and subsequent dialogs. If you believe this error is due to a bug in Evergreen and not network problems, please contact your help desk or friendly Evergreen administrators, and give them this information:
method=open-ils.circ.checkin
params=["xxxx",{"barcode":"xxxxxxxxxxxxxxx"}]
THROWN:
{"fileName":"oils://remote/xul/rel_3_0_20140228_095954/server/util/network.js","lineNumber":49}
STATUS:

Debug output:

Please open a helpdesk ticket and include the following text:

Tue Mar 04 2014 09:36:37 GMT-0500 (Eastern Standard Time)

Check In Failed (in circ.util.checkin) (3):

{
 "fileName":"oils://remote/xul/rel_3_0_20140228_095954/server/circ/util.js",
 "lineNumber":2954
}