Comment 9 for bug 1189989

I was trying to track down the error, by commenting out the changes in Account.pm and adding bits back in... and I also ran autogen.sh again. But now I just un-commented all the changes in Account.pm, and it works fine.

So running autogen.sh again must have fixed it?

I'm trying it again now. And no go, I ran autogen.sh and the error was still there.

It's almost like it only works after one successful hold has already been placed.

I can get it to work by doing the following.
1. Install from master, start everything up run autogen.

2. Try to place a hold, get internal server error. (Not selecting suspend or thaw_date)

3. Edit "/usr/local/share/perl/5.20.2/OpenILS/WWW/EGCatLoader/Account.pm" and comment out line 1254 "thaw_date=> $thaw_date" and adjust the comma.

4. Restart opensrf services and apache. (Restarting with editing Account.pm doesn't change the outcome).

5. Place a hold, it now works.

6. Un-comment change I made to Account.pm and adjust the comma.

7. Restart opensrf services and apache.

8. Place a suspended hold with a thaw date, now it works correctly, no error.

I tried a different user and placed a suspended hold and that account also with no trouble. I'm not sure how to track this down.

Also, as an enhancement to this, if the "Hold Sucessfullly placed" screen showed more info about the state of the hold, I think that would be useful. Like "Hold was successfully placed, in a suspended state to be thawed on 11/24/2015 and picked up at the example branch 1." To give the customer a confirmation that their choices were respected. But that is probably a new bug.