Comment 1 for bug 1152863

Revision history for this message
Dan Scott (denials) wrote :

After a quick read of the code, _prepare_biblio_search_boolean() concerns me; it's globbing and parsing files on disk for each and every search? Typically that would happen once, at startup time, and the results would be cached thereafter.

The location of the boolean localization files in the "/location/" directory seems a bit strange. Is that a placeholder for a better name?

Also, if I understand correctly, searching for "To be or not to be" is no longer going to result in highly relevant results for that phrase (as just a quick example that comes to mind). That concerns me, too, as a major change in behaviour.