(In reply to Mark Wielaard from comment #27)
> But this also handles DW_FORM_rnglistx and DW_FORM_loclistx.
> Shouldn't setup_cu_bases also handle these?
And that is what patch4 does.
> And if so, should we have an skip_Form_contents function that can be used in
> both places?
Still a good idea, but not super urgent.
Found once small issue with patch4:
+ case DW_FORM_rnglistx:
+ case DW_FORM_loclistx:
+ return VARSZ_FORM;
+ return VARSZ_FORM;
(In reply to Mark Wielaard from comment #27)
> But this also handles DW_FORM_rnglistx and DW_FORM_loclistx.
> Shouldn't setup_cu_bases also handle these?
And that is what patch4 does.
> And if so, should we have an skip_Form_contents function that can be used in
> both places?
Still a good idea, but not super urgent.
Found once small issue with patch4:
+ case DW_FORM_rnglistx:
+ case DW_FORM_loclistx:
+ return VARSZ_FORM;
+ return VARSZ_FORM;
Removed the duplicate return and pushed as:
commit d19bbdf1200685d dbb6976cf915fba 25f2097162
Author: Luboš Luňák <email address hidden>
Date: Tue Apr 19 12:20:16 2022 +0200
read dwarf5 DW_FORM_rnglistx and DW_FORM_loclistx
The .debug_ rnglists/ .debug_ loclists sections first have a list of offsets
and then a list of the actual data that those offsets point to.