Comment 27 for bug 955035

Revision history for this message
Margarita Manterola (marga-9) wrote :

Timo, thanks for the reply, I've been reading the discussion in the other bug, and I had a look at the code and the reverted patch.

I'm not sure how the other patch actually fixed this issue. The code for "layoutThumbsAll" looks much simpler than the current "layoutThumbs", and nothing seems to be explicitly done to prevent this problem. I'm guessing that the problem that causes this bug is in this piece of complex code, which is not present at all in the other one:

    for (std::map<ScaleWindow *, ScaleSlot>::iterator it = slotWindows.begin ();
         it != slotWindows.end (); it++)
    {
        slots.push_back (it->second);
        windows.push_back (it->first);
        it->first->priv->slot = &slots.back ();
        it->first->priv->slot->setX (it->first->priv->slot->x () + (it->first->priv->window->defaultViewport ().x () - screen->vp ().x ()) * screen->width ());
        it->first->priv->slot->setY (it->first->priv->slot->y () + (it->first->priv->window->defaultViewport ().y () - screen->vp ().y ()) * screen->height ());
    }

But I don't see where exactly the problem lies.