New charm proposal: graphite

Hi James,

Ok, my first charm review...

stopper:
- needs some sort of license (I just grab them from other charms)

recommendations/discussion:

- the install hook looks simple and straightforward. It might be useful to log the setup installs since you're installing from a branch and not a package as that's more likely to fail over time. Doesn't really matter though because either way you'll know it failed.

- no need to open internal ports (2003) unless you intend for them to be external someday. Everything's open internally for the foreseeable future.

- maybe use an upstart script for your service to survive reboots? I'd test a failed startup, you might need a 'set -e' for the start hook to catch a startup error from the subshell correctly... dunno.

removing new-charm tag

please add this back when the charm is updated and it'll automatically get put in the review queue again.

Thanks!

[Expired for Juju Charms Collection because there has been no activity for 60 days.]

Hi,

lp:~james-w/charms/precise/graphite/trunk

has a much-improved version of this charm.

Thanks,

James

Hey,

lp:~paulcz/charms/precise/graphite/trunk

is an improvement again on James Westby's charm, includes amqp support and documented hookup with sensu via rabbitmq

Hi Paul,

This is by no means an exhaustive review, but I did have a few comments:

- I'm not sure of the advantage of cat-ing files directly from the install hook rather than including them in a files directory and then copying them - this way you have a separation of content from logic (/etc/apache2/httpd.conf, /opt/graphite/conf/graphite.wsgi,/opt/graphite/webapp/graphite/local_settings.py).
- Since you're using apache, maybe it'd be worth considering doing this as a subordinate to the apache2 charm so that you get all of the advantages of using that charm (performance tuning of apache itself, ability to use SSL certs, etc.).
- It'd be nice to have other options for installing graphite than downloading directly from github.com, doing pip installs - in many corporate environments the place you're deploying from will have egress firewalls that may prevent access to these. If someone has a package location or other means of installing graphite it'd be good to support this.
- It seems odd to have the following comment in the configuration file you're creating:
# XXX In order for the django admin site media to work you
# must change @DJANGO_ROOT@ to be the path to your django
# installation, which is probably something like:
- There seems to be an empty appamor directory

Thanks, Tom

Also, wouldn't you need to be able to configure /opt/graphite/conf/storage-schemas.conf via the charm, otherwise you have no control over the retention of data?

I've done some work on this as well now. It's a first pass.

lp:~cjohnston/+junk/graphite

Hi Chris,

This looks okay at first glance. I haven't done a full review of it, but the approach is certainly better, and it's good to be able do include a custom storage-schemas.conf. I'm not sure about how we'd plan to be able to update that as there's no mechanism to deliver an updated version as far as I can see. Would there be any chance of updating it to allow for a mechanism to deliver an updated storage-schemas.conf file if needed?

Thanks, Tom