Comment 3 for bug 1528390

These charms and charm modifications are of a very high quality and my comments below are fairly minor. Thank you for proposing this valuable
addition to the charm store.

astara-neutron-api:
The config changed hook only rerenders config files. This makes the options exposed in config.yaml immutable, is that by design? if so
it would be worth being explicit about that in option description.

astara-orchestrator:
The code to ensure only the lead unit runs and db syncs appears to be missing. Immutable config comment from above is also applicable here.

Tests:
As noted in the bug comment there are currently no unit or functional tests included in the charms. These are a prerequisite for
including the charms in the curated charm store.

Changes to other charms:
The two branches mentioned in the bug description...

https://code.launchpad.net/~astara-drivers/charms/trusty/glance/api-ready
https://code.launchpad.net/~astara-drivers/charms/trusty/neutron-api/api-ready

...look good to me once unit tests have been updated.

I'm assuming that there should also be a keystone update as the keystone charm maintains a list of known services and astara
is not on that list so registration will fail.