I'm going to pin a few notes on the bug report as we had some back and forth over IRC in #Juju
- Cryptographic signature verification for external files are a hard requirement. I feel it would be a good idea for you to implement git as your delivery mechanism since you're considering continuous delivery on your application. I agree that multiple reviews a week will not scale well - so the experience for you *and* your charm users would decline sharply as time goes on and the workload changes.
- it also appears we were pointed at a stale branch somewhere, i don't recall where I was looking but I do see some of the modifications that you have called out specifically in your review.
I didn't notice any idempotency issues or hard blockers for inclusion in the store.
Thank you again for your patience with the review process as there has been quite a bit of back and forth on the metis charm. Don't forget I've offered to assist in whatever manner you require, just ping me in #juju on irc.freenode.net when you would like to cache in that token.
I'm going to move this back into incomplete pending the delivery of git based file distribution and at such a time the review should go quickly. When you're ready with the requested modifications mark the bug as "Fix Committed" again and someone will be along shortly to review your work.
Greetings Josh,
I'm going to pin a few notes on the bug report as we had some back and forth over IRC in #Juju
- Cryptographic signature verification for external files are a hard requirement. I feel it would be a good idea for you to implement git as your delivery mechanism since you're considering continuous delivery on your application. I agree that multiple reviews a week will not scale well - so the experience for you *and* your charm users would decline sharply as time goes on and the workload changes.
- it also appears we were pointed at a stale branch somewhere, i don't recall where I was looking but I do see some of the modifications that you have called out specifically in your review.
I didn't notice any idempotency issues or hard blockers for inclusion in the store.
Thank you again for your patience with the review process as there has been quite a bit of back and forth on the metis charm. Don't forget I've offered to assist in whatever manner you require, just ping me in #juju on irc.freenode.net when you would like to cache in that token.
I'm going to move this back into incomplete pending the delivery of git based file distribution and at such a time the review should go quickly. When you're ready with the requested modifications mark the bug as "Fix Committed" again and someone will be along shortly to review your work.