Comment 5 for bug 1065666

Revision history for this message
Robert Ayres (robert-ayres) wrote :

I've reviewed your latest commit.

I've made a few minor changes here - lp:~robert-ayres/charms/precise/vdbench/trunk , in particular:

*Extracting vdbench tar using current user for owner+permissions.
*Protecting the vbench/output directory from modification. vdbench chmods this directory to 0777 recursively. Not sure why, but it's technically a local security flaw.
*Corrected the upgrade hook to call the right scripts and not call the install hook.

I've tested on EC2. Deploying units, upgrading units, re-deploying units all works.

If you're happy with my changes, I'd merge my branch to yours and change the status in this bug.

Thanks.