I just hit this while debugging some redeployed computes on a cloud being prepared for handover. I had to spend hours of time to dig in to figure out that the reason the neutron-sriov-agent package wasn't being installed (in response to a nova-compute-relation-joined hook triggering the enable_openstack handler) was because of enable-auto-restarts being set to false. And it does basically break automation of redeploys; to get redeploys to work cleanly without the charm going into an error state, we need to set enable-auto-restarts to true prior to doing so, and remember to set enable-auto-restarts back to false afterwards.
I just hit this while debugging some redeployed computes on a cloud being prepared for handover. I had to spend hours of time to dig in to figure out that the reason the neutron-sriov-agent package wasn't being installed (in response to a nova-compute- relation- joined hook triggering the enable_openstack handler) was because of enable- auto-restarts being set to false. And it does basically break automation of redeploys; to get redeploys to work cleanly without the charm going into an error state, we need to set enable- auto-restarts to true prior to doing so, and remember to set enable- auto-restarts back to false afterwards.