Love the tests, symbols files, and clean packaging! :)
Blockers:
- Needs a team bug subscriber (a team that looks after this package in main, I assume ~touch-packages, which is currently subscribed, is not actually watched by anyone, and is just for bookkeeping?)
- In the spirit of the above, UDM shouldn't keep bugs in two places: bug 1478462. That just makes it harder to maintain, and means that the designated team might miss a bug.
- I'm confused on whether there are user-visible strings in u-d-m... If so, they should be translatable. (There might be some error messages in src/uploads/priv/ubuntu/uploads/file_upload.cpp... maybe elsewhere? I'm not familiar with the code.)
Other notes:
- Critical crasher bug 1411866 has been reported with reproduction steps for seven and half months, with no progress. That's not a comforting sign of maintenance.
- UDM runs daemons, sometimes as root. This should have a security lookover, so assigning to ~ubuntu-security.
- E: ubuntu-download-manager source: build-depends-on-metapackage build-depends: qt5-default
- W: libubuntu-download-manager-client-doc: embedded-javascript-library usr/share/doc/ubuntu-download-manager/cpp/html/jquery.js please use libjs-jquery
Love the tests, symbols files, and clean packaging! :)
Blockers: priv/ubuntu/ uploads/ file_upload. cpp... maybe elsewhere? I'm not familiar with the code.)
- Needs a team bug subscriber (a team that looks after this package in main, I assume ~touch-packages, which is currently subscribed, is not actually watched by anyone, and is just for bookkeeping?)
- In the spirit of the above, UDM shouldn't keep bugs in two places: bug 1478462. That just makes it harder to maintain, and means that the designated team might miss a bug.
- I'm confused on whether there are user-visible strings in u-d-m... If so, they should be translatable. (There might be some error messages in src/uploads/
Other notes: download- manager source: build-depends- on-metapackage build-depends: qt5-default download- manager- client- doc: embedded- javascript- library usr/share/ doc/ubuntu- download- manager/ cpp/html/ jquery. js please use libjs-jquery
- Critical crasher bug 1411866 has been reported with reproduction steps for seven and half months, with no progress. That's not a comforting sign of maintenance.
- UDM runs daemons, sometimes as root. This should have a security lookover, so assigning to ~ubuntu-security.
- E: ubuntu-
- W: libubuntu-