On Sat, Oct 08, 2011 at 11:31:10AM -0000, John A Meinel wrote:
> The other option to putting it in bzrlib.smart.request.request_handlers
> registry under 'info' is to just add it as an attribute of the
> individual classes. The problem is I would be tempted to use inheritance
> to avoid repeating myself, and that would mean new requests have not
> been analyzed for safe/unsafe.
I know what you mean. (And another factor here is it's ok for e.g. a
plugin to override the registration of an existing verb, and perhaps
that would be done by subclassing.)
But I think in practice new verbs are added sufficiently rarely that it
will make little difference either way, assuming you don't set retry_ok
= True in the base class.
On Sat, Oct 08, 2011 at 11:31:10AM -0000, John A Meinel wrote: smart.request. request_ handlers
> The other option to putting it in bzrlib.
> registry under 'info' is to just add it as an attribute of the
> individual classes. The problem is I would be tempted to use inheritance
> to avoid repeating myself, and that would mean new requests have not
> been analyzed for safe/unsafe.
I know what you mean. (And another factor here is it's ok for e.g. a
plugin to override the registration of an existing verb, and perhaps
that would be done by subclassing.)
But I think in practice new verbs are added sufficiently rarely that it
will make little difference either way, assuming you don't set retry_ok
= True in the base class.